Change the test expectation md5 hash

[philderbeast]

See #9486. Change the test expectation md5Hash for two tests.

I also removed MIN_VERSION_base(4,7,0) conditionals as we can't build anyway before ghc-8.4.

• Patches conform to the coding conventions.

[philderbeast]

Why has the hash has changed?

[andreabedini]

Why has the hash has changed?

I guess if some types from base change their representation, it might get get reflected in our Structure description.

[andreabedini]

👍

[Mikolaj]

If we were sure what's the cause of this discrepancy, it would be valuable to explain it in comments just before the ifdefs (e.g., if it comes from GHC vs from base, for the future, where one GHC can handle multiple base versions). But since we are not sure, this is good enough. Thank you.

[philderbeast]

I got a test failure in CI, with Validate macos-latest ghc-9.2.8 but it doesn't seem related. @Mikolaj can we prod just that one test to run again?

-----BEGIN CABAL OUTPUT-----
Error: cabal: '/usr/local/opt/curl/bin/curl' exited with an error:
curl: (7) Failed to connect to localhost port 8000 after 0 ms: Couldn't connect to server
-----END CABAL OUTPUT-----

[philderbeast]

Label merge+no rebase is necessary when the pull request is from an organisation.

[Mikolaj]

Oh, yes, that's a known CI brittleness, I've done "Rerun failed jobs" from the CI screen, top-right corner (no idea what permission level is needed fro that).

[philderbeast]

The expected hashes were changed by @ulysses4ever in b2a36b7#diff-9ae45287f208ec36cc58ec4d1cef44d473e504c09fd24ff8d5eb6d58f1a83707 but I still think this pull request is worthwhile.

[ulysses4ever]

Good job, thank you!

[mpickering]

Why has the hash changed? (Which type in base has changed its representation?)

[ulysses4ever]

I don't think anyone had an idea how to investigate that when I asked on Matrix what to do about it when upgrading to GHC 9.8.