Refactor buildComponent and replComponent #9475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheaf
force-pushed
the
wip/buildComponent
branch
2 times, most recently
from
08db0f1
to
488f7c2
Compare
alt-romes
force-pushed
the
wip/buildComponent
branch
4 times, most recently
from
01991b1
to
9db2722
Compare
sheaf
force-pushed
the
wip/buildComponent
branch
from
9db2722
to
566d43d
Compare
andreabedini
approved these changes
Dec 1, 2023
|
While I am ok with this going in as it is (as said, it is an improvement!) I am quite unhappy with the general pattern we seem to have through the codebase of pushing case-splits "down" the data flow. IMHO they should be pushed up instead. |
This is a pure refactor that reduces code duplication, with the exception that it also fixes a bug in that `preprocessExtras` was not being called for foreign libraries in both functions.
andreabedini
force-pushed
the
wip/buildComponent
branch
from
566d43d
to
07560a0
Compare
|
Nobody commented in 2 weeks, so let me set the label for @sheaf not to delay the merge even more. |
mergify
bot
added
the
merge delay passed
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Apr 22, 2024
This is a pure refactor that reduces code duplication, with the exception that it also fixes a bug in that `preprocessExtras` was not being called for foreign libraries in both functions. Co-authored-by: Rodrigo Mesquita <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactor that reduces code duplication, with the exception that it also fixes a bug in that
preprocessExtraswas not being called for foreign libraries in both functions.