Allow package to be listed twice in cabal.project #9449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is a desired change, I'll add a testsuite case to the MR. |
This makes `checkTarget` a little smarter by deduplicating the
`TargetPackage` so as not to error out when the user has the line
package: .
twice in their `cabal.project`.
Fixes haskell#9448
alt-romes
force-pushed
the
wip/romes/9448
branch
from
3b85e6f
to
3f7d175
Compare
ffaf1
reviewed
Nov 30, 2023
ffaf1
approved these changes
Nov 30, 2023
|
How can we merge this? Is there a label or should I just click the button? |
ffaf1
added
squash+merge me
|
Yup, I did it for you this time, now wait patiently for CI to go green + two more days. |
mergify
bot
added
the
merge delay passed
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Apr 22, 2024
This makes `checkTarget` a little smarter by deduplicating the
`TargetPackage` so as not to error out when the user has the line
package: .
twice in their `cabal.project`.
Fixes haskell#9448
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
checkTargeta little smarter by deduplicating theTargetPackageso as not to error out when the user has the linetwice in their
cabal.project.Fixes #9448