Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the pkg: prefix for package targets (backport #9015) #9079

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 1, 2023

This is an automatic backport of pull request #9015 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added the backport label Jul 1, 2023
@Kleidukos Kleidukos merged commit c7915c2 into 3.10 Jul 1, 2023
38 checks passed
@Kleidukos Kleidukos deleted the mergify/bp/3.10/pr-9015 branch July 1, 2023 18:59
@ulysses4ever
Copy link
Collaborator

It's funny but the bot should actually merge backports on its own. But it's been quite a while and it didn't. I wonder why...

@Kleidukos
Copy link
Member

image

My understanding is that we are not targeting master

@ulysses4ever
Copy link
Collaborator

@Kleidukos we do have a rule for backports specifically, we just forgot the label, it seems...
2023-07-01_15-07-1688240132

@Kleidukos
Copy link
Member

hmm weird I do recall having had to merge some PRs that had the label but were not taken by Mergify despite that.

@ulysses4ever
Copy link
Collaborator

I remember such cases with PRs that weren't backports. But I don't claim this couldn't happen with backports: software (including bots) falls for bugs more often than we'd like it to...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants