Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haddock-project: add CommonSetupFlags #10393

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

haddock-project: add CommonSetupFlags #10393

wants to merge 3 commits into from
+252 −205

Conversation

9999years
Copy link
Collaborator

@9999years 9999years commented Sep 27, 2024 •
edited
Loading

Split off of #10292. This lets cabal haddock-project use the standard CommonFlags that other commands use to set verbosity and so on.

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

@9999years 9999years force-pushed the wiggles/haddock-project-parse-common-flags branch from f2afeea to 89cb6a8 Compare September 27, 2024 23:35
@9999years 9999years changed the title haddock-project: add CommonFlags haddock-project: add CommonSetupFlags Sep 27, 2024
geekosaur
geekosaur approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: API change, can't be backported.

@9999years 9999years mentioned this pull request Sep 28, 2024
Open
5 tasks
@9999years
Add type and documentation to toSavedConfig
70bd545 
This helper function was challenging to understand, so I added
an explicit type signature and documentation comments to it.
@9999years
Move addFields to ParseUtils, add aliasField helper
4c24d03 
`addFields` should be in `ParseUtils` with the rest of the field
helpers.
@9999years 9999years force-pushed the wiggles/haddock-project-parse-common-flags branch from 89cb6a8 to 7fa0e5e Compare September 30, 2024 16:55
@9999years 9999years mentioned this pull request Sep 30, 2024
Open
2 tasks
@9999years 9999years force-pushed the wiggles/haddock-project-parse-common-flags branch from 7fa0e5e to 14510a9 Compare September 30, 2024 17:51
@9999years 9999years marked this pull request as ready for review September 30, 2024 18:40
@9999years 9999years added the merge me Tell Mergify Bot to merge label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@mpickering mpickering Awaiting requested review from mpickering

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@9999years @geekosaur