Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on Intel Macs and make a prerelease for them #10372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Sep 18, 2024

This runs overnight, so it doesn't bog down PRs.

I'm not sure the prerelease part will work; we'll just have to see.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • [ ] Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). scheduled workflows only run on master

Depends-on: #10363

@geekosaur
Copy link
Collaborator Author

About the only way this can be tested is to commit it, since it has to be on master and has to be scheduled by GHA.

@geekosaur geekosaur force-pushed the intel-macs-overnight branch 2 times, most recently from f3699dd to 85170b5 Compare September 18, 2024 03:46
@ulysses4ever
Copy link
Collaborator

What about the main validate workflow: should it avoid testing these now?

@geekosaur
Copy link
Collaborator Author

The whole point of this PR is that when #10363 (which is marked above as a Depends-on:) lands, Intel Macs won't be tested or prereleased at all.

@ulysses4ever
Copy link
Collaborator

Good!

@geekosaur
Copy link
Collaborator Author

There's a significant question here: how much of the validate workflow do we want to run? It could be argued that full validation on AArch64 is good enough, but it could also be argued that that's inviting bitrot. (If we want to run most or all of the validate workflow, I'll want to split that into reusable components that can be shared between this job and the main workflow.)

This runs overnight, so it doesn't bog down PRs.

I'm not sure the prerelease part will work; we'll just have to see.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants