Always pass ghc-options (backport #8717)

[mergify]

The documentation for ghc-shared-options states that they are
combined with ghc-options:

Additional options for GHC when the package is built as shared library. The options specified via this field are combined with the ones specified via ghc-options, and are passed to GHC during both the compile and link phases.

However, only ghc-shared-options and not ghc-options are passed in many cases.

This is an issue because it requires setting ghc-shared-options even if the shared (dynamic) parts of the build don't actually need different options; this has the unpleasant side-effect of causing modules to be compiled twice, effectively doubling compile time! See here, where any non-empty ghc-shared-options causes Cabal to not set -dynamic-too:

cabal/Cabal/src/Distribution/Simple/GHC.hs

Lines 1466 to 1469 in acbc0f3

	-- Should we use -dynamic-too instead of compiling twice?
	useDynToo = dynamicTooSupported && isGhcDynamic
	&& doingTH && withStaticExe
	&& null (hcSharedOptions GHC bnfo)

This issue was discovered while integrating the mold linker with a Haskell project; when ghc-shared-options wasn't set to the same value as ghc-options, the gold linker would be used instead of mold for various links during the build.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

I've tested this by using Cabal with this patch applied to build a large commercial Haskell project (the mercury.com backend) and saw that the ghc-options were correctly applied (in this case, that meant observing that no links were performed with gold and all links were correctly performed with mold, as the options requested, with the exception of the single link described in #4439).

Possibly related issues:

• cabal does not respect ghc-options for -pgmc, -pgml etc #4439
• Shared libraries on OSX not linked with framework dependencies or custom ld flags #2715
• ghc-options mega issue #7998

---

This is an automatic backport of pull request #8717 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 9c775f2 has failed:

On branch mergify/bp/3.12/pr-8717
Your branch is up to date with 'origin/3.12'.

You are currently cherry-picking commit 9c775f2f6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Cabal/src/Distribution/Simple/GHCJS.hs
	new file:   changelog.d/pr-8717

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Cabal/src/Distribution/Simple/GHC.hs
	both modified:   doc/cabal-package-description-file.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally