Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn that scripts cannot be package executables #10326

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Warn that scripts cannot be package executables #10326

merged 2 commits into from
Sep 11, 2024

Conversation

philderbeast
Copy link
Collaborator

@philderbeast philderbeast commented Sep 6, 2024 •
edited
Loading

See #10324. Add a warning to the user guide to say that scripts cannot be part of a package, as executable mains or other modules.

malteneuss
malteneuss previously approved these changes Sep 7, 2024
View reviewed changes
@malteneuss malteneuss added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Sep 7, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 7, 2024
@malteneuss malteneuss removed merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period labels Sep 7, 2024
@malteneuss malteneuss dismissed their stale review September 7, 2024 19:32

ulysses4ever taking over with good suggestions

ulysses4ever
ulysses4ever approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 9, 2024
@philderbeast
Copy link
Collaborator Author

Label merge+no rebase is necessary when the pull request is from an organisation.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Sep 11, 2024
@mergify mergify bot merged commit 1077091 into haskell:master Sep 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@malteneuss malteneuss Awaiting requested review from malteneuss

Assignees
No one assigned
Labels
documentation merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge+no rebase ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philderbeast @geekosaur @malteneuss @ulysses4ever