Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate.sh: Use Bash explicitly #10318

Merged
merged 1 commit into from
Sep 8, 2024
Merged

validate.sh: Use Bash explicitly #10318

merged 1 commit into from
Sep 8, 2024

Conversation

9999years
Copy link
Collaborator

We were already relying on Bash features like echo -e, so let's make it official.

geekosaur
geekosaur approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already had to fix a few Bash-isms (cf. #10174), so yes.

ulysses4ever
ulysses4ever approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bin/sh is always a mistake

@9999years 9999years added the merge me Tell Mergify Bot to merge label Sep 6, 2024
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 6, 2024
@9999years @Mikolaj
validate.sh: Use Bash explicitly
9fcc539 
We were already relying on Bash features like `echo -e`, so let's make
it official.
@mergify mergify bot merged commit 64f8254 into haskell:master Sep 8, 2024
49 checks passed
@geekosaur
Copy link
Collaborator

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 14, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 14, 2024
Merged
mergify bot added a commit that referenced this pull request Sep 14, 2024
@mergify
Merge pull request #10345 from haskell/mergify/bp/3.12/pr-10318
6d39c95 
`validate.sh`: Use Bash explicitly (backport #10318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9999years @geekosaur @ulysses4ever