Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand and unify --keep-temp-files #10292

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Sep 27, 2024

  1. Filter CommonSetupFlags more consistently in UnpackedPackage

    In haskell#10292, we will move the `--keep-temp-files` setting into
    `CommonSetupFlags` and out of `ReplFlags`/`HaddockFlags`. This means
    that the flag-filtering behavior (which adapts flags from new versions
    of `cabal-install` to old version of `Cabal`) will need to know which
    command is being run to provide the correct `CommonSetupFlags`.
    
    Therefore, this change adds several new `filterFooFlags` functions to
    provide this behavior, and removes the `commonFlags` used for all
    subcommands in `Distribution.Client.ProjectBuilding.UnpackedPackage`.
    9999years committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    be4358c View commit details
    Browse the repository at this point in the history
  2. Move addFields to ParseUtils, add aliasField helper

    `addFields` should be in `ParseUtils` with the rest of the field
    helpers.
    9999years committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    bae9b37 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8280e78 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc47a2f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5124bef View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3b85a0b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c22e11d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a8abc3b View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Expand and unify --keep-temp-files

    Currently, `cabal repl` has a `--keep-temp-files` option, and
    `cabal.project` has a `keep-temp-files` option but it only effects
    Haddock builds.
    
    This patch adds `--keep-temp-files` to `CommonSetupFlags`, making it
    available to all commands. The expanded `--keep-temp-files` flag is used
    for the `cabal repl` command and Haddock builds (retaining compatibility
    with the previous behavior) but is also used to determine when to keep
    response files.
    9999years committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3f8a3d3 View commit details
    Browse the repository at this point in the history