make cabal-install integration tests hermetic (backport #10205) #10218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
They were using the user's config, which is a problem if they don't have one or if it contains settings that interfere with tests (such as `documentation: True`). I'm not entirely certain of this, but it seems to work here. It's a bit of a hack, though. (cherry picked from commit cd45432)
2 tasks
geekosaur
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were using the user's config, which is a problem if they don't have one or if it contains settings that interfere with tests (such as
documentation: True).I'm not entirely certain of this, but it seems to work here. It's a bit of a hack, though.
Closes: #10187
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR:
This is an automatic backport of pull request #10205 done by [Mergify](https://mergify.com).