Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix write-ghc-environment-files documentation #10214

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Fix write-ghc-environment-files documentation #10214

merged 1 commit into from
Jul 21, 2024

Conversation

noughtmare
Copy link
Collaborator

@noughtmare noughtmare commented Jul 19, 2024 •
edited
Loading

"older" sounds like it means "earlier" (e.g. 8.2, 8.0 etc.) to me.

ffaf1
ffaf1 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I would change the title to something more intellegible (e.g. "Fix cabal.project documentation”).

@noughtmare
Copy link
Collaborator Author

OK, let me rename the commit

@noughtmare noughtmare closed this Jul 19, 2024
@noughtmare noughtmare reopened this Jul 19, 2024
@noughtmare noughtmare changed the title older -> later Fix write-ghc-environment-files documentation Jul 19, 2024
@ffaf1
Copy link
Collaborator

ffaf1 commented Jul 19, 2024

Thanks.
Now put a merge me label, wait two days and you are set!

@noughtmare noughtmare added the merge me Tell Mergify Bot to merge label Jul 19, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jul 21, 2024
@mergify mergify bot merged commit 705b6eb into master Jul 21, 2024
15 checks passed
@mergify mergify bot deleted the noughtmare-patch-2 branch July 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noughtmare @ffaf1 @geekosaur @ulysses4ever