Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cabal-install-solver synopsis (fix #10183) #10192

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Jul 9, 2024

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • [NO] Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur
Copy link
Collaborator

I wonder if we can say more, like why it's separate. I think someone said they were using a different solver locally, and this made it easier to swap solvers out?

@ulysses4ever
Copy link
Collaborator Author

@geekosaur good point. That's below my pay grade, sadly. We'd need someone with better understanding of things to phrase it carefully.. @grayjay, would you be interested in putting together a couple of sentences about the mission and potential use cases of cabal-install-solver as a separate package? We could put them in the package description. Currently it's pretty low on content...

@geekosaur
Copy link
Collaborator

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Jul 14, 2024

backport 3.12

✅ Backports have been created

@geekosaur geekosaur requested a review from grayjay August 1, 2024 19:14
@ulysses4ever ulysses4ever added the squash+merge me Tell Mergify Bot to squash-merge label Aug 1, 2024
@ulysses4ever
Copy link
Collaborator Author

Oh, I forgot about it completely! Setting the label...

@geekosaur
Copy link
Collaborator

I thought you were waiting for @grayjay to comment.

@ulysses4ever
Copy link
Collaborator Author

I think it's too simple of a change to bother Kristen. But there is a two-day delay still!

@grayjay
Copy link
Collaborator

grayjay commented Aug 2, 2024

Sorry I missed this. I'm not very familiar with the decision to split the solver into another package. It's possible that the same goal could be met by moving it into a sub-library within cabal-install, though I don't know whether cabal-install can use the sub-libraries feature yet. I do know that cabal-install-solver currently doesn't have a stable interface. I think that it would take some work to turn it into a library that could be easily depended upon. For example, the solver unit tests test the solver through an interface that is still part of cabal-install.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Aug 3, 2024
@mergify mergify bot merged commit 5f766d2 into master Aug 3, 2024
50 checks passed
@mergify mergify bot deleted the cabal-install-solver-synopsis branch August 3, 2024 23:41
mergify bot pushed a commit that referenced this pull request Aug 3, 2024
* Update cabal-install-solver synopsis (fix #10183)

* fixup! remove trailing dot

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 5f766d2)

# Conflicts:
#	cabal-install-solver/cabal-install-solver.cabal
geekosaur pushed a commit that referenced this pull request Aug 3, 2024
* Update cabal-install-solver synopsis (fix #10183)

* fixup! remove trailing dot

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 5f766d2)
mergify bot added a commit that referenced this pull request Aug 4, 2024
Update cabal-install-solver synopsis (fix #10183) (backport #10192)
mpickering pushed a commit to mpickering/cabal that referenced this pull request Aug 12, 2024
* Update cabal-install-solver synopsis (fix haskell#10183)

* fixup! remove trailing dot

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal-install-solver package description synopsis is a copypasto from cabal-install
4 participants