Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows tests #10186

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Fix Windows tests #10186

merged 8 commits into from
Jul 18, 2024

Conversation

jasagredo
Copy link
Collaborator

@jasagredo jasagredo commented Jul 7, 2024

  • fixes the local+noindex uri in withRepo which enables many tests on Windows (just a matter of \\ -> /)
  • normalizes some more output on Windows (\\ -> / but also removing C:\\)
  • provide skip*IO functions on IO () to quickly discard tests without having to setup a test env
  • un-skip and fix a bunch of tests here and there

55 tests in total which were skipped or expected broken on Windows now are passing:

➜ diff \
    <(rg -v "SKIP no cabal-install \(" code/cabal/out.txt | rg "(known|SKIP)" | awk '{print $1}' | sort -u) \
    <(rg -v "SKIP no cabal-install \(" master.out | rg "SKIP" | awk '{print $1}' | sort -u) \
    | rg "^>" | wc -l
55

and 66-55=11 tests were previously being skipped and now are marked as known failure, with an issue number:

➜ diff \
    <(rg -v "SKIP no cabal-install \(" code/cabal/out.txt | rg "SKIP" | awk '{print $1}' | sort -u) \
    <(rg -v "SKIP no cabal-install \(" master.out | rg "SKIP" | awk '{print $1}' | sort -u) \
    | rg "^>" | wc -l
66

@mpickering
Copy link
Collaborator

If CI works, then this looks good to me.

@jasagredo jasagredo force-pushed the js/windows-tests branch 2 times, most recently from 52f1994 to b0b04a8 Compare July 8, 2024 23:06
@jasagredo jasagredo changed the title Mark Windows tests as broken not skip Fix Windows tests Jul 8, 2024
@jasagredo jasagredo marked this pull request as ready for review July 8, 2024 23:27
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for so much clarity and information for the future self and future us.

@jasagredo jasagredo added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jul 15, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jul 17, 2024
@jasagredo jasagredo added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days and removed merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jul 18, 2024
@mergify mergify bot merged commit eacb6d0 into haskell:master Jul 18, 2024
46 checks passed
@jasagredo
Copy link
Collaborator Author

Thanks for the rebase(s) @Mikolaj 😄

@geekosaur
Copy link
Collaborator

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Jul 18, 2024

backport 3.12

✅ Backports have been created

@ulysses4ever
Copy link
Collaborator

Perhaps, this PR should have been squashed?..

@jasagredo
Copy link
Collaborator Author

Yeah, perhaps...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants