Don't merge: Remove includes-field
#10153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sol
commented
Jun 26, 2024
| @@ -443,8 +443,6 @@ checkBuildInfoPathsWellFormedness bi = do | |||
| mapM_ | |||
| (checkPath False "hs-source-dirs" PathKindDirectory . getSymbolicPath) | |||
| (hsSourceDirs bi) | |||
| -- Possibly absolute paths. | |||
| mapM_ (checkPath True "includes" PathKindFile . getSymbolicPath) (includes bi) | |||
There was a problem hiding this comment.
This code checked that includes exist and that the paths are well-formed.
sol
commented
Jun 26, 2024
| @@ -2499,7 +2499,7 @@ checkForeignDeps pkg lbi verbosity = | |||
| explainErrors missingHdr missingLibs | |||
| ) | |||
| where | |||
| allHeaders = collectField (fmap getSymbolicPath . includes) | |||
| allHeaders = [] | |||
There was a problem hiding this comment.
This area of the code checked that a dummy C program that includes any headers listed under includes can be compiled successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not meant to be merged!
This PR demonstrates that
includesare not used by anything. It's meant to aid the discussion of #10145 and #10147; it can be closed after.