Remove path forcibly on cabal clean on Windows

haskell · Jul 15, 2024 · b0df28a · b0df28a
1 parent 2fbfd55
commit b0df28a
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/cabal-install/src/Distribution/Client/CmdClean.hs b/cabal-install/src/Distribution/Client/CmdClean.hs
@@ -52,6 +52,10 @@ import Distribution.Simple.Utils
   , info
   , wrapText
   )
+import Distribution.System
+  ( OS (Windows)
+  , buildOS
+  )
 import Distribution.Utils.Path hiding
   ( (<.>)
   , (</>)
@@ -74,6 +78,7 @@ import System.Directory
   , listDirectory
   , removeDirectoryRecursive
   , removeFile
+  , removePathForcibly
   )
 import System.FilePath
   ( (</>)
@@ -168,7 +173,11 @@ cleanAction (ProjectFlags{..}, CleanFlags{..}) extraArgs _ = do
         let distRoot = distDirectory distLayout
 
         info verbosity ("Deleting dist-newstyle (" ++ distRoot ++ ")")
-        handleDoesNotExist () $ removeDirectoryRecursive distRoot
+        handleDoesNotExist () $
+          if buildOS == Windows
+            then -- Windows can't delete some git files #10182
+              removePathForcibly distRoot
+            else removeDirectoryRecursive distRoot
 
     removeEnvFiles $ distProjectRootDirectory distLayout
 

diff --git a/changelog.d/pr-10190 b/changelog.d/pr-10190
@@ -0,0 +1,11 @@
+synopsis: Fix `cabal clean` permissions on Windows
+packages: cabal-install
+prs: #10190
+issues: #10182
+significance:
+
+description: {
+
+- `cabal clean` now removes the `dist-newstyle` folder forcibly on Windows.
+
+}