Simplified test suite that runs on Windows and MacOS #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
requested changes
May 13, 2023
andreasabel
requested changes
May 14, 2023
|
@andreasabel Looks like haskell-actions/setup@v2 works with GHC 9.4.5. |
andreasabel
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #84, it's good idea to add test suite before messing with code generation that would interplay with C preprocessor. This test suite also runs Linux builds to help establish whether it's working at all as opposed to not working due to some Windows-related issue.
What's missing is that tests run with the C preprocessor that comes bundled with GHC. As outlined deep in #84, some issues were present with cpphs preprocessor that Agda used at the time.
It seems test suite could be parameterised by the C preprocessor, but it seems it would be best done on a test suite that uses testing framework like
tasty. That would bring other benefits like being able to run specific tests through command-line selectors. Perhaps the makefile-based test suite is overdue to be updated?