Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-1469: Move Python libraries from hashintel/hash into labs #3647

Merged

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

This moves the Python libraries to hashintel/labs and removes the Python worker.

🔗 Related links

🚫 Blocked by

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • affected the execution graph, and the turbo.json's have been updated to reflect this

@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/tests New or updated tests area/apps area/apps > hash-graph area/infra > terraform type/legal Owned by the @legal team labels Nov 29, 2023
@vilkinsons
Copy link
Member

vilkinsons commented Nov 29, 2023

@TimDiekmann I think Ciaran was removing the worker as part of #3644

Just saw your comment on that PR

@TimDiekmann
Copy link
Member Author

TimDiekmann commented Nov 29, 2023

Yes, I just did the changes here as well so I could test the CI without Python being installed. As this PR won't be merged before the other PR is in, git will see the changes.

@vilkinsons
Copy link
Member

@TimDiekmann Great, tag me when this needs approval.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.93%. Comparing base (19418a6) to head (75fd966).
Report is 1606 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3647      +/-   ##
==========================================
- Coverage   28.28%   27.93%   -0.35%     
==========================================
  Files         274      276       +2     
  Lines       13118    13286     +168     
  Branches      851      881      +30     
==========================================
+ Hits         3710     3712       +2     
- Misses       9391     9557     +166     
  Partials       17       17              
Flag Coverage Δ
apps.hash-ai-worker-ts 21.77% <ø> (ø)
apps.hash-api 0.00% <ø> (ø)
deer 13.86% <ø> (ø)
error-stack 76.70% <ø> (ø)
local.hash-backend-utils 10.95% <ø> (-5.36%) ⬇️
local.hash-subgraph 22.88% <ø> (ø)
sarif 87.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…lhash-into-labs

# Conflicts:
#	apps/README.md
#	libs/@local/hash-isomorphic-utils/src/graphql/type-defs/knowledge/entity.typedef.ts
@github-actions github-actions bot removed the area/tests New or updated tests label Nov 29, 2023
@TimDiekmann TimDiekmann marked this pull request as ready for review November 29, 2023 17:30
@TimDiekmann TimDiekmann requested a review from a team as a code owner November 29, 2023 17:30
@TimDiekmann TimDiekmann added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit efbe97a Nov 29, 2023
103 of 104 checks passed
@TimDiekmann TimDiekmann deleted the t/h-1469-move-python-libraries-from-hashintelhash-into-labs branch November 29, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-graph area/apps area/deps Relates to third-party dependencies (area) area/infra > terraform area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team type/legal Owned by the @legal team
Development

Successfully merging this pull request may close these issues.

2 participants