Making Injector NetworkPolicy Namespace Scoped (#909)

[amir-badar]

#909

[hashicorp-cla]

All committers have signed the CLA.

[heatherezell]

Hello @amir-badar - thank you for this submission! Can you let me know, was this a miss from the linked PR? Thanks!

[amir-badar]

@hsimon-hashicorp Is there a PR already raised for this issue? I can't see if you have put a reference link for that PR.

The problem which I have found is when you deploy this helm chart in a custom namespace it throws an error about Network Policy being missing for Namespace and as I have dig down i found that this object is not namespace scoped and so it throwing InvalidSpecError.

[dlydiard]

To give more context we are installing this chart with kustomize (helm enabled) + argo, so the namespace is required on the NetworkPolicy CR. The other injector charts seem to include the namespace, but it was missing for NetworkPolicy

[amir-badar]

@hsimon-hashicorp Do you have an ETA as to when this will be approved?

[tomhjp]

Thanks for raising this, in addition to my suggested edit, please can we get a bats unit test for this to validate? It doesn't look like we have any unit tests for the network policy yet, so you'll need to add a new file in test/unit