Fix bug creating serviceAccount for external Vault #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
added
bug
|
|
Iristyle
force-pushed
the
fix-serviceaccount-creation-for-external-vault
branch
from
f66a3bd
to
7a3028d
Compare
- Fixes serviceaccount specs to use the correct file (originally introduced in 2b2b0dd) - Fixed a bug with serviceAccount getting created even when an external Vault is specified
Iristyle
force-pushed
the
fix-serviceaccount-creation-for-external-vault
branch
from
7a3028d
to
bdd3fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled across this one while adding tests for #680
Fixes serviceaccount specs to use the correct file (originally
introduced in 2b2b0dd)
Fixed a bug with serviceAccount getting created even
when an external Vault is specified