Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_site_recovery_replicated_vm - support for the target_virtual_machine_size property #27480

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

catriona-m
Copy link
Member

@catriona-m catriona-m commented Sep 24, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Testing in TC

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #23729

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@catriona-m catriona-m marked this pull request as draft September 24, 2024 09:37
@catriona-m catriona-m marked this pull request as ready for review September 24, 2024 16:54
@catriona-m catriona-m requested a review from a team September 24, 2024 16:55
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But should we add another test step to update this?

@github-actions github-actions bot added size/XL and removed size/M labels Sep 26, 2024
@catriona-m
Copy link
Member Author

LGTM! But should we add another test step to update this?

Thanks! Added now 😸

@catriona-m catriona-m merged commit a877d29 into main Sep 26, 2024
32 checks passed
@catriona-m catriona-m deleted the cm/vmsize branch September 26, 2024 14:25
@github-actions github-actions bot added this to the v4.4.0 milestone Sep 26, 2024
catriona-m added a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for recoveryAzureVMSize on azurerm_site_recovery_replicated_vm
2 participants