Introduce OracleDatabase ExaData Infrastructure Resource & Data #27177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
requested changes
Sep 5, 2024
internal/services/oracledatabase/exadata_infrastructure_resource.go
Outdated
Show resolved
Hide resolved
eelhomsi
changed the title
katbyte
requested changes
Sep 24, 2024
website/docs/r/oracledatabase_exadata_infrastructure.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/oracledatabase_exadata_infrastructure.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/oracledatabase_exadata_infrastructure.html.markdown
Outdated
Show resolved
Hide resolved
| // WebsiteCategories returns a list of categories which can be used for the sidebar | ||
| func (r Registration) WebsiteCategories() []string { | ||
| return []string{ | ||
| "App Service", |
|
|
||
| // Name is the name of this Service | ||
| func (r Registration) Name() string { | ||
| return "App Service" |
Comment on lines
315
to
328
| var output ExadataInfraResourceModel | ||
|
|
||
| output.CustomerContacts = FlattenCustomerContacts(result.Model.Properties.CustomerContacts) | ||
| output.Name = pointer.ToString(result.Model.Name) | ||
| output.Location = result.Model.Location | ||
| output.Zones = result.Model.Zones | ||
| output.ResourceGroupName = id.ResourceGroupName | ||
| output.Tags = utils.FlattenPtrMapStringString(result.Model.Tags) | ||
| prop := result.Model.Properties | ||
| output.ComputeCount = pointer.From(prop.ComputeCount) | ||
| output.DisplayName = prop.DisplayName | ||
| output.StorageCount = pointer.From(prop.StorageCount) | ||
| output.Shape = prop.Shape | ||
| output.MaintenanceWindow = FlattenMaintenanceWindow(prop.MaintenanceWindow) |
There was a problem hiding this comment.
minor issue but to match other resources we should inline this/do an assingment
output := ExadataInfraResourceModel {
CustomerContacts: FlattenCustomerContacts(result.Model.Properties.CustomerContacts)
Name: pointer.ToString(result.Model.Name)
...
and such vs going outout.x
There was a problem hiding this comment.
Understood, I've updated the code.
| Optional: true, | ||
| Computed: true, | ||
| Elem: &pluginsdk.Schema{ | ||
| Type: pluginsdk.TypeInt, |
There was a problem hiding this comment.
this should be validated between 1-5?
There was a problem hiding this comment.
Internally we want 1-4, I've updated to validate that, thank you.
| "preference": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
this should be validated?
| Optional: true, | ||
| Computed: true, | ||
| Elem: &pluginsdk.Schema{ | ||
| Type: pluginsdk.TypeString, |
There was a problem hiding this comment.
and here?
please validate all properties
Comment on lines
497
to
502
| output.Name = id.CloudExadataInfrastructureName | ||
| output.ResourceGroupName = id.ResourceGroupName | ||
| output.Type = pointer.From(model.Type) | ||
| output.Tags = utils.FlattenPtrMapStringString(model.Tags) | ||
| output.Location = model.Location | ||
| output.Zones = model.Zones |
There was a problem hiding this comment.
why are these seperate and not included above?
There was a problem hiding this comment.
I've moved them up with the test.
…down Co-authored-by: kt <[email protected]>
…down Co-authored-by: kt <[email protected]>
…down Co-authored-by: kt <[email protected]>
… into introduce-exa-data-and-resource
katbyte
approved these changes
Sep 27, 2024
…e-exa-data-and-resource
I've added testing evidence here: |
…e-exa-data-and-resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
PRE-REVIEW - PLEASE DO NOT MERGE
Introduce OracleDatabase ExaData Infrastructure Resource & Data
Most relevant changes in:
internal/services/oracledatabase/PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Testing
ExadataInfraDataSourcetest:ExadataInfraResourcetests:Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.