-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute
- migrate legacy compute resources to hashicorp/go-azure-sdk
#25723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stephybun - Just one (possibly over paranoid) thing to check below, otherwise LGTM 🦈
return fmt.Errorf("Failed long polling for the stop of virtual machine %q: %+v", resourceGroup, err) | ||
ctx2, cancel := context.WithTimeout(ctx, 10*time.Minute) | ||
defer cancel() | ||
if err := client.Compute.VirtualMachinesClient.DeallocateThenPoll(ctx2, *id, virtualmachines.DefaultDeallocateOperationOptions()); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be completely sure, is the default option value (nil bool) treated the same as false
here? We sent an explicit false previously, so need to be careful the behaviour is the same after this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to send a false like we were previously doing
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
This updates the legacy compute resources to use
hashicorp/go-azure-sdk
and removes the last references to the legacy Azure Track1 SDK.Testing
Failing deprecated usage check can be ignored since the existing behaviour of the resource should be preserved
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
compute
- update legacy compute resources to usehashicorp/go-azure-sdk
[GH-00000]Note
If this PR changes meaningfully during the course of review please update the title and description as required.