-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore azurerm_nginx_configuration
resource and data source
#25402
Conversation
…ashicorp#24276)" This reverts commit 7a1f9f7.
azurerm_nginx_configuration
resource and data source.azurerm_nginx_configuration
resource and data source
@wuxu92 We'd like to restore this functionality for the reasons called out in the PR description. Until we have an internal discussion between us, Microsoft, and Terraform folks, can we please restore this functionality? Thanks!! |
Cross posting these from where the functionality was deprecated: |
Based on chats with @wuxu92, the below is a public facing example of a use-case for NGINXaaS that breaks if we retire the
This is a very common use-case for our service and will break if we retire the configuration resource. https://github.com/nginxinc/nginxaas-for-azure-snippets/blob/main/terraform/certificates/main.tf has these resources in action. Right now, I can create these resources in a single terraform run but if we embed the configuration inside the deployment, the user workflow breaks. I hope the above helps explain why this PR has been staged. |
LGTM! 👍 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Reverts #24276
There are a couple of things here:
With configuration now being inline, the use workflow breaks as
1
and3
cannot be separated.