Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore azurerm_nginx_configuration resource and data source #25402

Closed

Conversation

puneetsarna
Copy link
Contributor

Reverts #24276

There are a couple of things here:

  • The default configuration/import error issue was resolved. See changelog from March 13, 2024
  • This is a breaking change from a product use-case perspective as it breaks our HTTPS use-case where in the workflow is:
    1. Create deployment.
    2. Create certificate.
    3. Create configuration.

With configuration now being inline, the use workflow breaks as 1 and 3 cannot be separated.

@puneetsarna puneetsarna changed the title Restore azurerm_nginx_configuration resource and data source. Restore azurerm_nginx_configuration resource and data source Mar 25, 2024
@puneetsarna
Copy link
Contributor Author

puneetsarna commented Mar 25, 2024

@wuxu92 We'd like to restore this functionality for the reasons called out in the PR description. Until we have an internal discussion between us, Microsoft, and Terraform folks, can we please restore this functionality? Thanks!!

@puneetsarna
Copy link
Contributor Author

Cross posting these from where the functionality was deprecated:

#24276 (comment)

#24276 (comment)

@puneetsarna
Copy link
Contributor Author

Based on chats with @wuxu92, the below is a public facing example of a use-case for NGINXaaS that breaks if we retire the azurerm_nginx_configuration resource:

  1. The user first creates azurerm_nginx_deployment.
  2. The user proceeds to create the azurerm_nginx_certificate to add certificates to their deplyoment.
  3. The user proceeds to create the azurerm_nginx_configuration referencing the certificate via file paths (and the added depends_on to ensure sequence of operations) to secure their deployment.

This is a very common use-case for our service and will break if we retire the configuration resource.

https://github.com/nginxinc/nginxaas-for-azure-snippets/blob/main/terraform/certificates/main.tf has these resources in action. Right now, I can create these resources in a single terraform run but if we embed the configuration inside the deployment, the user workflow breaks.

I hope the above helps explain why this PR has been staged.

@agazeley
Copy link
Contributor

agazeley commented Apr 4, 2024

LGTM! 👍

@puneetsarna
Copy link
Contributor Author

  • Need to deprecate the new embedded fields.
  • Add a test for certs and configs being used together to establish a workflow contract.

@puneetsarna
Copy link
Contributor Author

#25740 superseded this PR. closing it in favor of #25740.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants