Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_nginx_deployment - support for the configuration block #24276

Merged
merged 4 commits into from
Mar 22, 2024
Merged

azurerm_nginx_deployment - support for the configuration block #24276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
734c975
embed nginx configuration into deployment resource
wuxu92 Dec 19, 2023
42b69c7
return deprecate in favour of resource
wuxu92 Mar 22, 2024
f2d6de0
ignore not found error for configuration get operation
wuxu92 Mar 22, 2024
e3e9055
format
wuxu92 Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions internal/services/nginx/nginx_configuration_data_source_test.go
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions internal/services/nginx/nginx_configuration_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,15 @@ func (c ConfigurationModel) ToSDKModel() nginxconfiguration.NginxConfiguration {

type ConfigurationResource struct{}

// This resource has been deprecated and will be removed in the next major release.
// Default Nginx Configuration cannot be created anymore for service API breaking change created it automatically
// nginx configuration block is now embedded into nginx deployment resource
func (m *ConfigurationResource) DeprecatedInFavourOfResource() string {
return "azurerm_nginx_deployment"
}

var _ sdk.Resource = (*ConfigurationResource)(nil)
var _ sdk.ResourceWithDeprecationReplacedBy = &ConfigurationResource{}

func (m ConfigurationResource) Arguments() map[string]*pluginsdk.Schema {
return map[string]*pluginsdk.Schema{
Expand Down
257 changes: 0 additions & 257 deletions internal/services/nginx/nginx_configuration_resource_test.go
View file
Open in desktop

This file was deleted.

Loading
Loading