docs: add to resource_app_id description and fix typos in service_principals.md #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Thanks @nayrsirhc, aside from a slight formatting issue, this LGTM!
Please feel free to continue suggesting improvements to the provider docs, particularly around Applications if we have missed something or we can be more explicit.
|
Its a pleasure and thank you @manicminer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: add to resource_app_id description and fix typos in service_principals.md
I was recently using this provider and had some confusion from my side as I was unaware client id and application id were synonomous for one another, I use the terraform provider docs religiously and I believe that because application id is a property that is now deperecated this description should be changed to match what the provider expects, which from what I can tell is client id