Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PIM Group management #1327

Merged
merged 57 commits into from
May 8, 2024
Merged

Add support for PIM Group management #1327

merged 57 commits into from
May 8, 2024

Commits on Feb 29, 2024

  1. Enable typed resources for identitygovernance

    @oWretch
    oWretch committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0e3b0cc View commit details
    Browse the repository at this point in the history

  2. Create azuread_privileged_access_group_assignment_schedule_request

    @oWretch
    oWretch committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b14959b View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Handle deletion of requests in all states

    @oWretch
    oWretch committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    003e26d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Initial test creation

    @oWretch
    oWretch committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    cccc742 View commit details
    Browse the repository at this point in the history

  2. Handle case where the request comes back failed from Entra

    @oWretch
    oWretch committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    f72d4ee View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Create azuread_privileged_access_group_eligibility_schedule_request

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    11408d5 View commit details
    Browse the repository at this point in the history

  2. Create tests for azuread_privileged_access_group_eligibility_schedule… 

    …_request
    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b27b94e View commit details
    Browse the repository at this point in the history

  3. Enable typed resources for Policies

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    236a7b0 View commit details
    Browse the repository at this point in the history

  4. Create clients

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f6ac361 View commit details
    Browse the repository at this point in the history

  5. Initial resource for PAM Group policies

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    dc2facb View commit details
    Browse the repository at this point in the history

  6. Initial CRUD functions

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7b1a840 View commit details
    Browse the repository at this point in the history

  7. Correct schema errors

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8beaa4f View commit details
    Browse the repository at this point in the history

  8. Fix Create function

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    bb74378 View commit details
    Browse the repository at this point in the history

  9. Fix ID issues

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7ddb94e View commit details
    Browse the repository at this point in the history

  10. Add parsing for role policies

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    07cc7c2 View commit details
    Browse the repository at this point in the history

  11. Finish migrating settings into blocks

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f163e04 View commit details
    Browse the repository at this point in the history

  12. Rename AllowPermanent to ExpirationRequired 

    Better matches the underlying resource and means
we don't need to negate the bool
    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    08b6a3d View commit details
    Browse the repository at this point in the history

  13. Update policy build code to actually work

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1dbc70a View commit details
    Browse the repository at this point in the history

  14. Read now works also

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    66ac6af View commit details
    Browse the repository at this point in the history

  15. Update parameter requirements

    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    d370422 View commit details
    Browse the repository at this point in the history

  16. Rename all resource etc with Group prefix 

    Preparation for doing Directory and DirectoryRole resources
    @oWretch
    oWretch committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7fcfbce View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. We have working tests

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2acc9de View commit details
    Browse the repository at this point in the history

  2. Add documentation 

    Rename some fields to make more sense
    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8dede21 View commit details
    Browse the repository at this point in the history

  3. Rename approval_stages to approval_stage

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    65c7657 View commit details
    Browse the repository at this point in the history

  4. Ensure all additional_recipients blocks have an item

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2a655fe View commit details
    Browse the repository at this point in the history

  5. Rename base object_id to group_id

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a6b7c04 View commit details
    Browse the repository at this point in the history

  6. Update primary_approver block to better match the underlying API

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    78ac258 View commit details
    Browse the repository at this point in the history

  7. Fix duplicate approval_stages being saved in the state file

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0fd0004 View commit details
    Browse the repository at this point in the history

  8. Allow additional_recipients to be an empty list

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2dd6c6a View commit details
    Browse the repository at this point in the history

  9. Convert Lists to Sets where order doesn't matter

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1318798 View commit details
    Browse the repository at this point in the history

  10. DRY processing notification settings

    @oWretch
    oWretch committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    43f03a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Reverse nesting of notification blocks to match the GUI layout

    @oWretch
    oWretch committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5598a54 View commit details
    Browse the repository at this point in the history

  2. Update Import section of the documentation

    @oWretch
    oWretch committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    07037ad View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refs/heads/f/pim-group-eligible-schedule' into f/pim-gr… 

    …oups

# Conflicts:
#	internal/provider/services.go
    @oWretch
    oWretch committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9902481 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refs/heads/f/pim-group-assign-schedule' into f/pim-groups 

    # Conflicts:
#	internal/services/identitygovernance/client/client.go
    @oWretch
    oWretch committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c57208f View commit details
    Browse the repository at this point in the history

  5. Fix naming issues after merge

    @oWretch
    oWretch committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d409233 View commit details
    Browse the repository at this point in the history

  6. Ensure all validation functions are ValidateDiagFuncs

    @oWretch
    oWretch committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    3f079cc View commit details
    Browse the repository at this point in the history

  7. Catch error where no valid expiry defined

    @oWretch
    oWretch committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0c66c13 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Combine common code for schedule requests

    @oWretch
    oWretch committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    78ce8d2 View commit details
    Browse the repository at this point in the history

  2. Better validation of start and expiry dates

    @oWretch
    oWretch committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    44aec6d View commit details
    Browse the repository at this point in the history

  3. Centralise schedule resource build

    @oWretch
    oWretch committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2edafda View commit details
    Browse the repository at this point in the history

  4. Suppress diff on the start date

    @oWretch
    oWretch committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bb2237b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Update read functions to find the lastest request version

    @oWretch
    oWretch committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    1dd653f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Correct ordering of arguments in documentation

    @oWretch
    oWretch committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    832971c View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Bump hamilton to v0.67.0

    @oWretch
    oWretch committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a0f4dff View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Make Group Role Management documentation clearer

    @oWretch
    oWretch committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c1d6e25 View commit details
    Browse the repository at this point in the history

  2. Add full validation function for role management policy IDs

    @oWretch
    oWretch committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1681630 View commit details
    Browse the repository at this point in the history

  3. Create custom importer for group role management policy

    @oWretch
    oWretch committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0bd0aef View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Move to managing schedules rather than requests

    @oWretch
    oWretch committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f71d75f View commit details
    Browse the repository at this point in the history

  2. Handle the change in ID for policies when updated

    @oWretch
    oWretch committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a4a0726 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Fix golint errors

    @oWretch
    oWretch committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a71fe54 View commit details
    Browse the repository at this point in the history

  2. add basis for a data source to retrieve group role management policy … 

    …id (#1)

Add role management policy data source
    @iwarapter
    iwarapter authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fcc6044 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Correct notification rule example

    @oWretch
    oWretch committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ef8f613 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. identitygovernance: don't mark as gone when we've actively destroyed … 

    …a resource
    @manicminer
    manicminer committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9f53c2d View commit details
    Browse the repository at this point in the history

  2. data.azuread_group_role_management_policy: fix up acceptance test

    @manicminer
    manicminer committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2af400c View commit details
    Browse the repository at this point in the history

  3. doc fixups

    @manicminer
    manicminer committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8c2cdfe View commit details
    Browse the repository at this point in the history

  4. make generate

    @manicminer
    manicminer committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4e071f8 View commit details
    Browse the repository at this point in the history