Fix owners memory leak

hashicorp · Oct 4, 2024 · e35ae5c · e35ae5c
1 parent 3d969c4
commit e35ae5c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/services/groups/group_resource.go b/internal/services/groups/group_resource.go
@@ -1137,7 +1137,7 @@ func groupResourceUpdate(ctx context.Context, d *pluginsdk.ResourceData, meta in
 		}
 
 		existingOwners := make([]string, 0)
-		for resp.Model != nil {
+		if resp.Model != nil {
 			for _, o := range *resp.Model {
 				existingOwners = append(existingOwners, pointer.From(o.DirectoryObject().Id))
 			}

diff --git a/internal/services/groups/group_resource_test.go b/internal/services/groups/group_resource_test.go
@@ -1021,7 +1021,7 @@ resource "azuread_application" "test" {
 
 resource "azuread_service_principal" "test" {
   count          = 27
-  application_id = azuread_application.test[count.index].application_id
+  client_id = azuread_application.test[count.index].client_id
 }
 
 resource "azuread_user" "test" {