Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Add int32 type, attribute, and function support #1010

Merged
merged 12 commits into from
Jun 26, 2024
Merged

all: Add int32 type, attribute, and function support #1010

merged 12 commits into from
Jun 26, 2024

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Jun 21, 2024

Closes: #801

This PR introduces Int32 type support to terraform-plugin-framework with the addition of:

  • Int32 type and value implementations: types.Int32Type and types.Int32
  • Custom type interfaces:basetypes.Int32Typable, basetypes.Int32Valuable and basetypes.Int32ValuableWithSemanticEquals
  • Attribute support: schema.Int32Attribute for resource, data source, and provider schemas
  • Function support: function.Int32Parameter and function.Int32Return
  • Int32 plan modifier interfaces and implementations (requires replace, use state if unknown, etc.)
  • Int32 default interfaces and static implementation
  • Int32 validation interface: validator.Int32

@SBGoods SBGoods requested a review from a team as a code owner June 21, 2024 17:13
austinvalle
austinvalle approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some suggestions in the PR

I see references to float32 attributes that don't exist but it seems likely they'll go in the same release of terraform-plugin-framework v1.10.0

.changes/unreleased/FEATURES-20240621-132424.yaml Outdated Show resolved Hide resolved
.changes/unreleased/FEATURES-20240621-132441.yaml Outdated Show resolved Hide resolved
provider/metaschema/int32_attribute.go Outdated Show resolved Hide resolved
website/docs/plugin/framework/handling-data/attributes/int32.mdx Outdated Show resolved Hide resolved
website/docs/plugin/framework/handling-data/attributes/int32.mdx Outdated Show resolved Hide resolved
website/data/plugin-framework-nav-data.json Outdated Show resolved Hide resolved
types/basetypes/int32_type.go Outdated Show resolved Hide resolved
types/basetypes/int32_type_test.go Show resolved Hide resolved
@austinvalle austinvalle added this to the v1.10.0 milestone Jun 24, 2024
@austinvalle austinvalle added the enhancement New feature or request label Jun 24, 2024
@SBGoods SBGoods merged commit 79b0229 into main Jun 26, 2024
29 checks passed
@SBGoods SBGoods deleted the SBGoods/int-float32 branch June 26, 2024 16:23
This was referenced Jun 26, 2024
Merged
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Add Int32 type
2 participants
@SBGoods @austinvalle