Release v1.2.3 (#19)

* fix: use outbound.send_trans_email (was o.send_email)
* dep(@haraka/eslint-config): bump ver

.eslintrc.yaml

@@ -7,4 +7,4 @@ env:
 extends: ['@haraka']
 
 rules:
-  no-unused-vars: 1
+  no-unused-vars: 1

CHANGELOG.md

@@ -4,11 +4,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).
 
 ### Unreleased
 
-### [1.2.2] - 2024-04-22
+### [1.2.3] - 2024-04-22
 
+- fix: use outbound.send_trans_email (was o.send_email)
 - populate [files] in package.json.
 - dep: eslint-plugin-haraka -> @haraka/eslint-config
 - lint: remove duplicate / stale rules from .eslintrc
+- prettier
+- ci: use more shared GHA workflows
+- doc(CONTRIBUTORS): added
+- doc(CHANGELOG): fixed version release URLs
 
 ### [1.2.1] - 2023-06-12
 
@@ -74,3 +79,4 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).
 [1.2.1]: https://github.com/haraka/haraka-plugin-qmail-deliverable/releases/tag/v1.2.1
 [1.2.2]: https://github.com/haraka/haraka-plugin-qmail-deliverable/releases/tag/v1.2.2
 [1.3.0]: https://github.com/haraka/haraka-plugin-qmail-deliverable/releases/tag/v1.3.0
+[1.2.3]: https://github.com/haraka/haraka-plugin-qmail-deliverable/releases/tag/v1.2.3

CONTRIBUTORS.md

@@ -2,7 +2,7 @@
 
 This handcrafted artisinal software is brought to you by:
 
-| <img height="80" src="https://avatars.githubusercontent.com/u/261635?v=4"><br><a href="https://github.com/msimerson">msimerson</a> (<a href="https://github.com/haraka/haraka-plugin-qmail-deliverable/commits?author=msimerson">23</a>) | <img height="80" src="https://avatars.githubusercontent.com/u/1674289?v=4"><br><a href="https://github.com/Dexus">Dexus</a> (<a href="https://github.com/haraka/haraka-plugin-qmail-deliverable/commits?author=Dexus">1</a>) | <img height="80" src="https://avatars.githubusercontent.com/u/550490?v=4"><br><a href="https://github.com/smfreegard">smfreegard</a> (<a href="https://github.com/haraka/haraka-plugin-qmail-deliverable/commits?author=smfreegard">1</a>) |
+| <img height="80" src="https://avatars.githubusercontent.com/u/261635?v=4"><br><a href="https://github.com/msimerson">msimerson</a> (<a href="https://github.com/haraka/haraka-plugin-qmail-deliverable/commits?author=msimerson">24</a>) | <img height="80" src="https://avatars.githubusercontent.com/u/1674289?v=4"><br><a href="https://github.com/Dexus">Dexus</a> (<a href="https://github.com/haraka/haraka-plugin-qmail-deliverable/commits?author=Dexus">1</a>) | <img height="80" src="https://avatars.githubusercontent.com/u/550490?v=4"><br><a href="https://github.com/smfreegard">smfreegard</a> (<a href="https://github.com/haraka/haraka-plugin-qmail-deliverable/commits?author=smfreegard">1</a>) |
 | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------: | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------: |
 
 <sub>this file is maintained by [.release](https://github.com/msimerson/.release)</sub>

README.md

@@ -10,16 +10,13 @@ On incoming messages (relaying=false), validate the RCPT TO address.
 
 ## Configuration
 
-The host and port that qmail-deliverabled is listening on can be set by
-altering the contents of `config/qmail-deliverable.ini`
+The host and port that qmail-deliverabled is listening on can be set in `config/qmail-deliverable.ini`
 
 - `host` (Default: localhost)
-
 - `port` (Default: 8998)
-
 - `check_mail_from`= (Default: true)
 
-When `check_mail_from` is enabled, the MAIL FROM address is checked for deliverability. The deliverable status can be inspected by checking `transaction.notes.local_sender`. This information can be used later to determine mail handling.
+When `check_mail_from` is enabled, the MAIL FROM address is checked for deliverability. The deliverable status can be inspected by checking `transaction.notes.local_sender`. This information can be used later to influence mail routing.
 
 ### Fine control of MX routing
 
@@ -34,11 +31,13 @@ MX routing for individual domains can be set by defining `queue` and `next_hop`.
 Domains can have their own configuration. The defaults are the same, so only the differences
 needs to be declared. Example:
 
+    ```ini
     [example.com]
     host=192.168.0.1
 
     [example2.com]
     host=192.168.0.2
+    ```
 
 <!-- leave these buried at the bottom of the document -->
 

index.js

@@ -266,7 +266,7 @@ exports.hook_queue = function (next, connection) {
     case 'lmtp':
     case 'outbound':
       this.logdebug(`routing to outbound: queue.wants=${qw}`)
-      outbound.send_email(connection.transaction, next)
+      outbound.send_trans_email(connection.transaction, next)
       break
     default:
       next() // do nothing

package.json

@@ -1,6 +1,6 @@
 {
   "name": "haraka-plugin-qmail-deliverable",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Haraka plugin that validates recipients against Qmail::Deliverable",
   "main": "index.js",
   "files": [
@@ -34,7 +34,7 @@
   },
   "homepage": "https://github.com/haraka/haraka-plugin-qmail-deliverable#readme",
   "devDependencies": {
-    "@haraka/eslint-config": "^1.1.3",
+    "@haraka/eslint-config": "^1.1.5",
     "address-rfc2821": "^2.1.2",
     "haraka-test-fixtures": "^1.3.7"
   }

test/index.js

@@ -1,5 +1,3 @@
-'use strict'
-
 const assert = require('assert')
 
 const Address = require('address-rfc2821').Address