Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3팀 김진현][Chapter 1-1] 프레임워크 없이 SPA 만들기 #15

Closed
wants to merge 12 commits into from
Closed
26 changes: 26 additions & 0 deletions src/classes/Router.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
export class Router {
constructor() {
this.routes = {};
window.addEventListener("popstate", this.handlePopState.bind(this));
}

addRoute(path, handler) {
this.routes[path] = handler;
}

navigateTo(path, replace = false) {
if (replace) history.replaceState({}, "", path);
else history.pushState({}, "", path);
this.handleRoute(path);
}

handlePopState() {
this.handleRoute(window.location.pathname);
}

handleRoute(path) {
const handler = this.routes[path];
if (handler) handler();
else this.navigateTo("/404");
}
}
23 changes: 23 additions & 0 deletions src/classes/User.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
export class User {
constructor() {
this.preferences = JSON.parse(localStorage.getItem("user")) || {};
}

set(key, value) {
this.preferences[key] = value;
this.save();
}

get(key) {
return this.preferences[key];
}

save() {
localStorage.setItem("user", JSON.stringify(this.preferences));
}

clear() {
this.preferences = {};
localStorage.removeItem("user");
}
}
6 changes: 6 additions & 0 deletions src/components/Footer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export function Footer() {
return `
<footer class="bg-gray-200 p-4 text-center">
<p>&copy; 2024 항해플러스. All rights reserved.</p>
</footer>`;
}
38 changes: 38 additions & 0 deletions src/components/Header.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { isLoggedIn } from "../main";

export function Header() {
const currentPath = window.location.pathname;

const profileLinkClass =
currentPath === "/profile" ? "text-blue-600" : "text-gray-600";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

경로부분이 하드코딩 되어있는데 상수로 뺀다면 더 편하게 관리할 수 있을거같아요!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵!ㅎㅎ 리뷰감사합니다 ㅎㅎ

const homeLinkeClass =
currentPath === "/" ? "text-blue-600 font-bold" : "text-gray-600";

return `
<header class="bg-blue-600 text-white p-4 sticky top-0">
<h1 class="text-2xl font-bold">항해플러스</h1>
</header>

<nav class="bg-white shadow-md p-2 sticky top-14">
<ul class="flex justify-around">
<li>
<a href="/" class="${homeLinkeClass} cursor-pointer">홈</a>
</li>
${
isLoggedIn()
? `<li>
<a href="/profile" class="${profileLinkClass} cursor-pointer">프로필</a>
</li>`
: ""
}
<li>
<a href="/login" class="text-gray-600 cursor-pointer" id=${
isLoggedIn() ? "logout" : "login"
}
>${isLoggedIn() ? "로그아웃" : "로그인"}</a
>
</li>
</ul>
</nav>`;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nav를 객체 배열로 만들어서 관리하는거 혹시 어떠신가요,,,!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map으로 반복문 돌리는거 말씀하시는거죠? ㅎㅎ 유지보수 측면에서 좋은 방법인거같습니다

164 changes: 53 additions & 111 deletions src/main.js
Original file line number Diff line number Diff line change
@@ -1,111 +1,53 @@
document.querySelector('#root').innerHTML = `
<div class="bg-gray-100 min-h-screen flex justify-center">
<div class="max-w-md w-full">
<header class="bg-blue-600 text-white p-4 sticky top-0">
<h1 class="text-2xl font-bold">항해플러스</h1>
</header>

<nav class="bg-white shadow-md p-2 sticky top-14">
<ul class="flex justify-around">
<li><a href="./main.html" class="text-blue-600">홈</a></li>
<li><a href="./profile.html" class="text-gray-600">프로필</a></li>
<li><a href="#" class="text-gray-600">로그아웃</a></li>
</ul>
</nav>

<main class="p-4">
<div class="mb-4 bg-white rounded-lg shadow p-4">
<textarea class="w-full p-2 border rounded" placeholder="무슨 생각을 하고 계신가요?"></textarea>
<button class="mt-2 bg-blue-600 text-white px-4 py-2 rounded">게시</button>
</div>

<div class="space-y-4">

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img src="https://via.placeholder.com/40" alt="프로필" class="rounded-full mr-2">
<div>
<p class="font-bold">홍길동</p>
<p class="text-sm text-gray-500">5분 전</p>
</div>
</div>
<p>오늘 날씨가 정말 좋네요. 다들 좋은 하루 보내세요!</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img src="https://via.placeholder.com/40" alt="프로필" class="rounded-full mr-2">
<div>
<p class="font-bold">김철수</p>
<p class="text-sm text-gray-500">15분 전</p>
</div>
</div>
<p>새로운 프로젝트를 시작했어요. 열심히 코딩 중입니다!</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img src="https://via.placeholder.com/40" alt="프로필" class="rounded-full mr-2">
<div>
<p class="font-bold">이영희</p>
<p class="text-sm text-gray-500">30분 전</p>
</div>
</div>
<p>오늘 점심 메뉴 추천 받습니다. 뭐가 좋을까요?</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img src="https://via.placeholder.com/40" alt="프로필" class="rounded-full mr-2">
<div>
<p class="font-bold">박민수</p>
<p class="text-sm text-gray-500">1시간 전</p>
</div>
</div>
<p>주말에 등산 가실 분 계신가요? 함께 가요!</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img src="https://via.placeholder.com/40" alt="프로필" class="rounded-full mr-2">
<div>
<p class="font-bold">정수연</p>
<p class="text-sm text-gray-500">2시간 전</p>
</div>
</div>
<p>새로 나온 영화 재미있대요. 같이 보러 갈 사람?</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>
</div>
</main>

<footer class="bg-gray-200 p-4 text-center">
<p>&copy; 2024 항해플러스. All rights reserved.</p>
</footer>
</div>
</div>
`;
import { Router } from "./classes/Router";
import { User } from "./classes/User";
import { HomePage } from "./pages/HomePage";
import { LoginPage } from "./pages/LoginPage";
import { NotFound } from "./pages/NotFound";
import { ProfilePage } from "./pages/ProfilePage";

export const router = new Router();
export const user = new User();
export function isLoggedIn() {
return user?.preferences?.username?.length > 0;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export �const isLoggedIn =() => user?.preferences?.username?.length > 0;

이런식으로 축약해서 사용할 수도 있을 것 같습니다~!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 넵 화살표함수로 작성하니 더 깔끔해보여 좋은거같습니다!

router.addRoute("/", HomePage);
router.addRoute("/profile", ProfilePage);
router.addRoute("/login", LoginPage);
router.addRoute("/404", NotFound);

export function handleRouting() {
const links = document.querySelectorAll("a");

links.forEach((link) => {
link.addEventListener("click", (e) => {
e.preventDefault();

if (e.target.getAttribute("href") === "/login") {
e.stopPropagation();
return;
}
router.navigateTo(e.target.getAttribute("href"));
});
});
}

export function Logout() {
const logoutEl = document.querySelector("#logout");
if (logoutEl)
logoutEl.addEventListener("click", () => {
user.clear();
router.navigateTo("/");
});
}

document.addEventListener("DOMContentLoaded", () => {
router.handleRoute(window.location.pathname);
});

window.addEventListener("error", (event) => {
const errorBoundary = document.createElement("div");
errorBoundary.id = "error-boundary";
errorBoundary.textContent = `오류 발생! ${event.message}`;
document.body.appendChild(errorBoundary);
});
132 changes: 132 additions & 0 deletions src/pages/HomePage.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
import { Footer } from "../components/Footer";
import { Header } from "../components/Header";
import { Logout, handleRouting } from "../main";

export function HomePage() {
let html;
html = ` <div class="bg-gray-100 min-h-screen flex justify-center">
<div class="max-w-md w-full">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html을 선언하고 한번만 할당하고 있어 const html = `` 이런식으로 바꿔 보는건 어떨까요~?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그러네요 ㅎㅎ 피드백 감사합니다!

<main class="p-4">
<div class="mb-4 bg-white rounded-lg shadow p-4">
<textarea
class="w-full p-2 border rounded"
placeholder="무슨 생각을 하고 계신가요?ㅋ"
></textarea>
<button class="mt-2 bg-blue-600 text-white px-4 py-2 rounded">
게시
</button>
</div>

<div class="space-y-4">
<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img
src="https://via.placeholder.com/40"
alt="프로필"
class="rounded-full mr-2"
/>
<div>
<p class="font-bold">홍길동</p>
<p class="text-sm text-gray-500">5분 전</p>
</div>
</div>
<p>오늘 날씨가 정말 좋네요. 다들 좋은 하루 보내세요!</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img
src="https://via.placeholder.com/40"
alt="프로필"
class="rounded-full mr-2"
/>
<div>
<p class="font-bold">김철수</p>
<p class="text-sm text-gray-500">15분 전</p>
</div>
</div>
<p>새로운 프로젝트를 시작했어요. 열심히 코딩 중입니다!</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img
src="https://via.placeholder.com/40"
alt="프로필"
class="rounded-full mr-2"
/>
<div>
<p class="font-bold">이영희</p>
<p class="text-sm text-gray-500">30분 전</p>
</div>
</div>
<p>오늘 점심 메뉴 추천 받습니다. 뭐가 좋을까요?</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img
src="https://via.placeholder.com/40"
alt="프로필"
class="rounded-full mr-2"
/>
<div>
<p class="font-bold">박민수</p>
<p class="text-sm text-gray-500">1시간 전</p>
</div>
</div>
<p>주말에 등산 가실 분 계신가요? 함께 가요!</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>

<div class="bg-white rounded-lg shadow p-4">
<div class="flex items-center mb-2">
<img
src="https://via.placeholder.com/40"
alt="프로필"
class="rounded-full mr-2"
/>
<div>
<p class="font-bold">정수연</p>
<p class="text-sm text-gray-500">2시간 전</p>
</div>
</div>
<p>새로 나온 영화 재미있대요. 같이 보러 갈 사람?</p>
<div class="mt-2 flex justify-between text-gray-500">
<button>좋아요</button>
<button>댓글</button>
<button>공유</button>
</div>
</div>
</div>
</main>
</div>
</div>`;
document.querySelector(
"#root"
).innerHTML = `<div class="bg-gray-100 min-h-screen flex justify-center">
<div class="max-w-md w-full">${Header()}${html}${Footer()}</div>
</div>`;

handleRouting();
Logout();
}
Loading
Loading