Refactor HTML Injection Form Component #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
guqing
pushed a commit
to guqing/plugin-injection
that referenced
this pull request
Sep 30, 2024
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 原来的注入表单组件`HtmlInjectionAdd`把新增和更改的逻辑混在一起了， 该PR删除了该组件并拆分成`HtmlInjectionForm`,`HtmlInjectionCreationModal`和`HtmlInjectionEditionModal`分别用于渲染表单，新增注入和修改注入 #### Which issue(s) this PR fixes: Fixes halo-sigs#7 #### Does this PR introduce a user-facing change? ```release-note None ```
CaiHaosen
added a commit
that referenced
this pull request
Oct 9, 2024
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 原来的注入表单组件`HtmlInjectionAdd`把新增和更改的逻辑混在一起了， 该PR删除了该组件并拆分成`HtmlInjectionForm`,`HtmlInjectionCreationModal`和`HtmlInjectionEditionModal`分别用于渲染表单，新增注入和修改注入 #### Which issue(s) this PR fixes: Fixes #7 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
原来的注入表单组件
HtmlInjectionAdd把新增和更改的逻辑混在一起了，该PR删除了该组件并拆分成
HtmlInjectionForm,HtmlInjectionCreationModal和HtmlInjectionEditionModal分别用于渲染表单，新增注入和修改注入Which issue(s) this PR fixes:
Fixes #7
Does this PR introduce a user-facing change?