Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose user and role services into plugins #6880

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature
/area plugin
/milestone 2.20.x

What this PR does / why we need it:

This PR exposes user and role services into plugins. Some authentication plugins may interact with users and users' roles.

Does this PR introduce a user-facing change?

允许在插件中使用 UserService 和 RoleService

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 16, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 16, 2024
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. area/plugin Issues or PRs related to the Plugin Provider labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.97%. Comparing base (eff73dc) to head (223e0b5).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6880      +/-   ##
============================================
- Coverage     56.99%   56.97%   -0.03%     
- Complexity     3999     4002       +3     
============================================
  Files           714      716       +2     
  Lines         24110    24191      +81     
  Branches       1585     1594       +9     
============================================
+ Hits          13742    13783      +41     
- Misses         9756     9792      +36     
- Partials        612      616       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang JohnNiang force-pushed the feat/expose-user-and-role-service-to-plugins branch from bdfd952 to 223e0b5 Compare October 16, 2024 09:06
Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
Copy link

f2c-ci-robot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit db4e68b into halo-dev:main Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugin Issues or PRs related to the Plugin Provider kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants