Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove underline in h2 warning alert #6849

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 13, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

before:

image

after:

image

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note-none Denotes a PR that doesn't merit a release note. labels Oct 13, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 13, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wzrove October 13, 2024 04:29
Copy link

sonarcloud bot commented Oct 13, 2024

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.02%. Comparing base (d7aba83) to head (a2883c4).
Report is 35 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6849      +/-   ##
============================================
- Coverage     57.03%   57.02%   -0.02%     
- Complexity     3978     3999      +21     
============================================
  Files           713      714       +1     
  Lines         23992    24098     +106     
  Branches       1570     1584      +14     
============================================
+ Hits          13685    13743      +58     
- Misses         9696     9743      +47     
- Partials        611      612       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2024
Copy link

f2c-ci-robot bot commented Oct 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 149cb5d into halo-dev:main Oct 13, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants