Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve remember-me option after authentication failure #6844

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR preserves remember-me option after authentication failure.

Which issue(s) this PR fixes:

Fixes #6835

Special notes for your reviewer:

  1. Go to login page
  2. Input invalid username or password and select remember-me option
  3. Click Login button
  4. See the result

Does this PR introduce a user-facing change?

修复登录失败后记住我选项被重置的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby October 12, 2024 10:04
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
@JohnNiang JohnNiang force-pushed the bug/remember-me-missing-after-login-failed branch from 6e734ad to a3de517 Compare October 12, 2024 10:36
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
Copy link

sonarcloud bot commented Oct 12, 2024

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.09%. Comparing base (d7aba83) to head (a3de517).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
...n/rememberme/WebSessionRememberMeRequestCache.java 0.00% 7 Missing ⚠️
...ation/rememberme/TokenBasedRememberMeServices.java 0.00% 1 Missing ⚠️
...alo/app/security/preauth/PreAuthLoginEndpoint.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6844      +/-   ##
============================================
+ Coverage     57.03%   57.09%   +0.05%     
- Complexity     3978     4001      +23     
============================================
  Files           713      714       +1     
  Lines         23992    24081      +89     
  Branches       1570     1582      +12     
============================================
+ Hits          13685    13750      +65     
- Misses         9696     9720      +24     
  Partials        611      611              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
Copy link

f2c-ci-robot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit b761fe2 into halo-dev:main Oct 12, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

登陆失败后重置了保持登录选项
2 participants