-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve remember-me option after authentication failure #6844
Preserve remember-me option after authentication failure #6844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: JohnNiang <[email protected]>
6e734ad
to
a3de517
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6844 +/- ##
============================================
+ Coverage 57.03% 57.09% +0.05%
- Complexity 3978 4001 +23
============================================
Files 713 714 +1
Lines 23992 24081 +89
Branches 1570 1582 +12
============================================
+ Hits 13685 13750 +65
- Misses 9696 9720 +24
Partials 611 611 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR preserves
remember-me
option after authentication failure.Which issue(s) this PR fixes:
Fixes #6835
Special notes for your reviewer:
remember-me
optionLogin
buttonDoes this PR introduce a user-facing change?