Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertical images are rotated to horizontal when generating thumbnails #6842

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 12, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

修复竖向图片生成缩略图后会丢失方向信息展示为横向图片的问题

Which issue(s) this PR fixes:

Fixes #6802

Does this PR introduce a user-facing change?

修复竖向图片生成缩略图后会丢失方向信息展示为横向图片的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby October 12, 2024 08:32
@guqing guqing force-pushed the refactor/thumbnail-orientation branch from d0253de to 2718db6 Compare October 12, 2024 08:39
Copy link

sonarcloud bot commented Oct 12, 2024

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (d7aba83) to head (2718db6).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...n/halo/app/core/attachment/ThumbnailGenerator.java 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main    #6842    +/-   ##
==========================================
  Coverage     57.03%   57.04%            
- Complexity     3978     4000    +22     
==========================================
  Files           713      714     +1     
  Lines         23992    24100   +108     
  Branches       1570     1585    +15     
==========================================
+ Hits          13685    13747    +62     
- Misses         9696     9741    +45     
- Partials        611      612     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 3bdec9e into halo-dev:main Oct 12, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 12, 2024
@guqing guqing deleted the refactor/thumbnail-orientation branch October 12, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

缩略图显示问题
2 participants