Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve login page ui #6832

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 12, 2024

What type of PR is this?

/area core
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

优化登录等页面的 UI,主要优化低分屏下的 UI 表现,防止元素过大。

Does this PR introduce a user-facing change?

优化登录等页面的 UI,优化低分屏下的 UI 表现,防止元素过大。

Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 12, 2024
Copy link

sonarcloud bot commented Oct 12, 2024

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.04%. Comparing base (d7aba83) to head (c6cdf3d).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6832   +/-   ##
=========================================
  Coverage     57.03%   57.04%           
- Complexity     3978     3991   +13     
=========================================
  Files           713      714    +1     
  Lines         23992    24074   +82     
  Branches       1570     1579    +9     
=========================================
+ Hits          13685    13733   +48     
- Misses         9696     9728   +32     
- Partials        611      613    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
Copy link

f2c-ci-robot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit b9da9d0 into halo-dev:main Oct 12, 2024
8 checks passed
@ruibaby ruibaby deleted the refactor/login-ui-2 branch October 12, 2024 09:22
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants