Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support locale-based validation messages based on users language #6819

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 11, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

优化校验提示信息根据用户选择的语言代替 Locale#getDefault()#getLanguage()

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby October 11, 2024 05:48
Copy link

sonarcloud bot commented Oct 11, 2024

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 57.10%. Comparing base (d7aba83) to head (a9a29c4).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...uthentication/twofactor/TwoFactorAuthEndpoint.java 0.00% 7 Missing ⚠️
...lo/app/security/preauth/PreAuthSignUpEndpoint.java 0.00% 2 Missing ⚠️
...halo/app/security/preauth/SystemSetupEndpoint.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6819      +/-   ##
============================================
+ Coverage     57.03%   57.10%   +0.06%     
- Complexity     3978     3989      +11     
============================================
  Files           713      714       +1     
  Lines         23992    24042      +50     
  Branches       1570     1576       +6     
============================================
+ Hits          13685    13728      +43     
- Misses         9696     9701       +5     
- Partials        611      613       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link

f2c-ci-robot bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit aab8806 into halo-dev:main Oct 11, 2024
8 checks passed
@guqing guqing deleted the refactor/validation-message branch October 11, 2024 07:18
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants