-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support locale-based validation messages based on users language #6819
refactor: support locale-based validation messages based on users language #6819
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6819 +/- ##
============================================
+ Coverage 57.03% 57.10% +0.06%
- Complexity 3978 3989 +11
============================================
Files 713 714 +1
Lines 23992 24042 +50
Branches 1570 1576 +6
============================================
+ Hits 13685 13728 +43
- Misses 9696 9701 +5
- Partials 611 613 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x
What this PR does / why we need it:
优化校验提示信息根据用户选择的语言代替
Locale#getDefault()#getLanguage()
Does this PR introduce a user-facing change?