Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restrict username and password length during user registration #6808

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 10, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

为注册用户增加用户名和密码长度校验

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang October 10, 2024 03:49
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen October 10, 2024 03:49
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.03%. Comparing base (d7aba83) to head (e341c8a).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...n/halo/app/core/endpoint/console/UserEndpoint.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6808      +/-   ##
============================================
- Coverage     57.03%   57.03%   -0.01%     
  Complexity     3978     3978              
============================================
  Files           713      713              
  Lines         23992    23999       +7     
  Branches       1570     1572       +2     
============================================
+ Hits          13685    13687       +2     
- Misses         9696     9700       +4     
- Partials        611      612       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Wang <[email protected]>
@JohnNiang
Copy link
Member

需要先解决一下冲突。

@guqing
Copy link
Member Author

guqing commented Oct 10, 2024

需要先解决一下冲突。

Done

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
Copy link

f2c-ci-robot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit fbe40c2 into halo-dev:main Oct 10, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants