-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve password confirmation validation for forms #6807
feat: improve password confirmation validation for forms #6807
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6807 +/- ##
============================================
+ Coverage 57.03% 57.06% +0.02%
- Complexity 3978 3980 +2
============================================
Files 713 713
Lines 23992 23992
Branches 1570 1570
============================================
+ Hits 13685 13692 +7
+ Misses 9696 9690 -6
+ Partials 611 610 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area core
/kind improvement
/milestone 2.20.x
What this PR does / why we need it:
完善部分表单的确定密码校验。
Does this PR introduce a user-facing change?