Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve password confirmation validation for forms #6807

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 10, 2024

What type of PR is this?

/area core
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

完善部分表单的确定密码校验。

  1. 封装单独的校验函数。
  2. 完善 i18n。
image

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/core Issues or PRs related to the Halo Core labels Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.06%. Comparing base (d7aba83) to head (00b1be7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6807      +/-   ##
============================================
+ Coverage     57.03%   57.06%   +0.02%     
- Complexity     3978     3980       +2     
============================================
  Files           713      713              
  Lines         23992    23992              
  Branches       1570     1570              
============================================
+ Hits          13685    13692       +7     
+ Misses         9696     9690       -6     
+ Partials        611      610       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
Copy link

f2c-ci-robot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 01a781c into halo-dev:main Oct 10, 2024
8 checks passed
@ruibaby ruibaby deleted the refactor/confirm-password-validation branch October 10, 2024 07:17
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants