Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve password input toggle button state display #6800

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 9, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

优化密码输入框的明文切换图标的状态显示。

before:

image

after:

image

Does this PR introduce a user-facing change?

优化密码输入框的明文切换图标的状态显示。

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/ui Issues or PRs related to the Halo UI labels Oct 9, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 9, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove October 9, 2024 06:07
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 9, 2024
Copy link

sonarcloud bot commented Oct 9, 2024

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
Copy link

f2c-ci-robot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.71%. Comparing base (5b2bdfd) to head (8e80fa8).
Report is 46 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6800      +/-   ##
============================================
- Coverage     58.00%   57.71%   -0.30%     
- Complexity     3977     4020      +43     
============================================
  Files           696      711      +15     
  Lines         23517    23917     +400     
  Branches       1567     1574       +7     
============================================
+ Hits          13641    13803     +162     
- Misses         9255     9493     +238     
  Partials        621      621              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit 82fb91f into halo-dev:main Oct 9, 2024
8 checks passed
@ruibaby ruibaby deleted the refactor/password-input branch October 9, 2024 07:06
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants