Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add LIlGG as a approver #6795

Merged
merged 1 commit into from
Oct 8, 2024
Merged

chore: add LIlGG as a approver #6795

merged 1 commit into from
Oct 8, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 8, 2024

What type of PR is this?

None

What this PR does / why we need it:

Add @LIlGG as a approver

Does this PR introduce a user-facing change?

None 

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG October 8, 2024 10:12
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LIlGG
Once this PR has been reviewed and has the lgtm label, please ask for approval from ruibaby. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby merged commit c39f937 into main Oct 8, 2024
7 of 8 checks passed
@ruibaby ruibaby deleted the ruibaby-patch-1 branch October 8, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants