Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve error message styling for reset password form #6791

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 8, 2024

What type of PR is this?

/area core
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

优化重置密码表单的错误提示样式。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note-none Denotes a PR that doesn't merit a release note. labels Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen October 8, 2024 08:57
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.88%. Comparing base (5b2bdfd) to head (4946a7a).
Report is 39 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6791      +/-   ##
============================================
- Coverage     58.00%   57.88%   -0.13%     
- Complexity     3977     4016      +39     
============================================
  Files           696      709      +13     
  Lines         23517    23851     +334     
  Branches       1567     1574       +7     
============================================
+ Hits          13641    13806     +165     
- Misses         9255     9423     +168     
- Partials        621      622       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@guqing
Copy link
Member

guqing commented Oct 8, 2024

/approve

Copy link

f2c-ci-robot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 16641e3 into halo-dev:main Oct 8, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants