Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redirect-on-login setting option from role editing form #6776

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 6, 2024

What type of PR is this?

/area ui
/kind api-change
/milestone 2.20.x

What this PR does / why we need it:

See #6774

Which issue(s) this PR fixes:

Fixes #6774

Does this PR introduce a user-facing change?

移除角色的 **登录之后默认跳转位置** 设置选项。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 6, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 6, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 6, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wan92hen October 6, 2024 12:49
Copy link

sonarcloud bot commented Oct 6, 2024

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.88%. Comparing base (982a45b) to head (ec3ca50).
Report is 41 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6776      +/-   ##
============================================
- Coverage     58.29%   57.88%   -0.41%     
- Complexity     3963     4007      +44     
============================================
  Files           680      709      +29     
  Lines         23338    23831     +493     
  Branches       1584     1574      -10     
============================================
+ Hits          13604    13794     +190     
- Misses         9108     9415     +307     
+ Partials        626      622       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
Copy link

f2c-ci-robot bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit d648928 into halo-dev:main Oct 7, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

移除角色的[登录之后默认跳转位置]选项
2 participants