feat: refine i18n for login method selection button #6771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <[email protected]>
f2c-ci-robot
bot
added
release-note-none
f2c-ci-robot
bot
added
the
kind/improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6771 +/- ##
============================================
- Coverage 58.00% 57.87% -0.13%
- Complexity 3977 4007 +30
============================================
Files 696 709 +13
Lines 23517 23846 +329
Branches 1567 1574 +7
============================================
+ Hits 13641 13801 +160
- Misses 9255 9423 +168
- Partials 621 622 +1 ☔ View full report in Codecov by Sentry. |
JohnNiang
requested changes
Oct 7, 2024
|
Fixed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area core
/kind improvement
/milestone 2.20.x
What this PR does / why we need it:
完善登录方式选择按钮的 i18n。
Which issue(s) this PR fixes:
Fixes #6759
Does this PR introduce a user-facing change?