Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to manage their attachments in uc #6731

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 29, 2024

What type of PR is this?

/kind feature
/milestone 2.20.x
/area core

What this PR does / why we need it:

支持用户在个人中心管理自己的附件(需要具有对应权限)

Fixes #5278

Does this PR introduce a user-facing change?

支持用户在个人中心管理自己的附件(需要具有对应权限)

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 29, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 29, 2024
@guqing
Copy link
Member Author

guqing commented Sep 29, 2024

@ruibaby 帮忙适配一下 UC

@guqing guqing force-pushed the feature/uc-attachments branch 2 times, most recently from 4930125 to 1221dea Compare September 30, 2024 02:42
Copy link

pkg-pr-new bot commented Sep 30, 2024

Open in Stackblitz

@halo-dev/api-client

pnpm add https://pkg.pr.new/@halo-dev/api-client@6731

@halo-dev/components

pnpm add https://pkg.pr.new/@halo-dev/components@6731

@halo-dev/console-shared

pnpm add https://pkg.pr.new/@halo-dev/console-shared@6731

@halo-dev/richtext-editor

pnpm add https://pkg.pr.new/@halo-dev/richtext-editor@6731

@halo-dev/ui-plugin-bundler-kit

pnpm add https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@6731

commit: 40422da

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 40.44118% with 81 lines in your changes missing coverage. Please review.

Project coverage is 57.71%. Comparing base (5b2bdfd) to head (40422da).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
...alo/app/core/endpoint/uc/UcAttachmentEndpoint.java 32.81% 43 Missing ⚠️
...va/run/halo/app/core/attachment/SearchRequest.java 53.70% 25 Missing ⚠️
...app/core/attachment/impl/AttachmentListerImpl.java 7.69% 12 Missing ⚠️
...rc/main/java/run/halo/app/infra/SystemSetting.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6731      +/-   ##
============================================
- Coverage     58.00%   57.71%   -0.30%     
- Complexity     3977     4020      +43     
============================================
  Files           696      711      +15     
  Lines         23517    23917     +400     
  Branches       1567     1574       +7     
============================================
+ Hits          13641    13803     +162     
- Misses         9255     9493     +238     
  Partials        621      621              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 3, 2024
@LIlGG
Copy link
Member

LIlGG commented Oct 8, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2585636 into halo-dev:main Oct 8, 2024
10 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

将 AttachmentSelectorModal 组件向个人中心全局注册
4 participants