Generic recipes: rework #161
Conversation
extrowerk
changed the title
|
Can someone wrap this one up? It'd be nice to have these in place in time for GCI |
|
Is there anything else what we want to include in the examples? |
| @@ -36,16 +36,48 @@ BUILD_PREREQUIRES=" | |||
| cmd:gcc | |||
| " | |||
|
|
|||
| defineDebugInfoPackage projectx \ | |||
| "$appsDir"/ProjectX | |||
There was a problem hiding this comment.
Do we really need to quote $appsDir?
There was a problem hiding this comment.
Better safe than sorry...
| @@ -17,7 +17,7 @@ SOURCE_DIR="$portVersionedName" | |||
| PATCHES="projectx-$portVersion.patchset" | |||
| ADDITIONAL_FILES="projectx.rdef" | |||
|
|
|||
| ARCHITECTURES="x86_gcc2 ?x86 ?x86_64" | |||
| ARCHITECTURES="?x86_gcc2 ?x86 ?x86_64" | |||
There was a problem hiding this comment.
Shouldn't we remove x86 here (and in other places), there is no primary architecture for that anymore (afaik)
There was a problem hiding this comment.
should update to show new use of 'all'
| GLOBAL_WRITABLE_FILES=" | ||
| settings/projectx.conf keep-old | ||
| " |
There was a problem hiding this comment.
GLOBAL_WRITABLE_FILES should be used before PROVIDES
| GLOBAL_WRITABLE_FILES=" | ||
| settings/projectx.rc keep-old # If there is any | ||
| " |
There was a problem hiding this comment.
Same here, needs to be declared before PROVIDES
| GLOBAL_WRITABLE_FILES=" | ||
| settings/projectx.rc keep-old # If there is any | ||
| " |
There was a problem hiding this comment.
Same here, should be declared before PROVIDES
| PYTHON_PACKAGES=(python python3) | ||
| PYTHON_VERSIONS=(2.7 3.6) |
There was a problem hiding this comment.
Maybe?
-PYTHON_PACKAGES=(python python3)
-PYTHON_VERSIONS=(2.7 3.6)
+PYTHON_PACKAGES=(python3.6 python3)
+PYTHON_VERSIONS=(3.6 3.7)
| @@ -17,7 +17,7 @@ SOURCE_DIR="$portVersionedName" | |||
| PATCHES="projectx-$portVersion.patchset" | |||
| ADDITIONAL_FILES="projectx.rdef" | |||
|
|
|||
| ARCHITECTURES="x86_gcc2 ?x86 ?x86_64" | |||
| ARCHITECTURES="?x86_gcc2 ?x86 ?x86_64" | |||
There was a problem hiding this comment.
should update to show new use of 'all'
| PATCHES="projectx-$portVersion.patchset" | ||
| ADDITIONAL_FILES="projectx.rdef" | ||
|
|
||
| ARCHITECTURES="?x86_gcc2 ?x86 ?x86_64" |
There was a problem hiding this comment.
should update to show new use of 'all'
| PATCHES="projectx-$portVersion.patchset" | ||
| ADDITIONAL_FILES="projectx.rdef" | ||
|
|
||
| ARCHITECTURES="?x86_gcc2 ?x86 ?x86_64" |
There was a problem hiding this comment.
should update to show new use of 'all'
| PATCHES="projectx-$portVersion.patchset" | ||
| ADDITIONAL_FILES="projectx.rdef" | ||
|
|
||
| ARCHITECTURES="any" |
There was a problem hiding this comment.
should update to show new use of 'all'?
No description provided.