Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the shared selection colors sane. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willoller
Copy link
Contributor

The monokai theme does not work well if the text-
background colors are very bright. It makes the
selected text very hard to read for the other user
in the same editor.

This uses darker muted versions of some monokai
colors, and assigns one at random to each user.

This could cause 2 users to have the same cursor
color, but unless there are 3+ simultaneous
editors, nobody will notice.

The monokai theme does not work well if the text-
background colors are very bright. It makes the
selected text very hard to read for the other user
in the same editor.

This uses darker muted versions of some monokai
colors, and assigns one at random to each user.

This could cause 2 users to have the same cursor
color, but unless there are 3+ simultaneous
editors, nobody will notice.
@hugorodrigues
Copy link
Member

Thanks for the PR, its a great improvement!
I'm currently traveling but i will test and merge ASAP.

You should expect a new release with your fixes in a couple of days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants