Release 1.3.3

h2zero · Nov 25, 2021 · 63d8c90 · 63d8c90
1 parent b9350bb
commit 63d8c90
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file.  
 
+## [1.3.3] - 2021-11-24
+
+### Fixed
+- Workaround added for FreeRTOS bug that affected timers, causing scan and advertising timer expirations to not correctly trigger callbacks.
+
 ## [1.3.2] - 2021-11-20
 
 ### Fixed

diff --git a/src/nimble/nimble_npl_os.h b/src/nimble/nimble_npl_os.h
@@ -235,7 +235,8 @@ ble_npl_callout_stop(struct ble_npl_callout *co)
 static inline bool
 ble_npl_callout_is_active(struct ble_npl_callout *co)
 {
-    /* Workaround for bug in xTimerIsTimerActive with latest arduino core.
+    /* Workaround for bug in xTimerIsTimerActive with FreeRTOS V10.2.0, fixed in V10.4.4
+     * See: https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/305
      * Sometimes xTimerIsTimerActive returns pdTRUE even though the timer has expired, so we double check.
      */
     return xTimerIsTimerActive(co->handle) == pdTRUE && xTimerGetExpiryTime(co->handle) > xTaskGetTickCountFromISR();