Install scale to user home

[atykhonov]

This PR changes the default installation directory from /usr/local/ to $HOME/.scale. Two executable links (scale and scale-ui) are installed in /usr/local/bin/ in the same way as it was.

I was thinking about usage of $HOME/.config/scale/ and $HOME/.config/pharo/ directories (instead of $HOME/.scale) accordingly to XDG specification. But most of the files which reside in these directories are executables (not user specific configuration files). So I decided to use $HOME/.scale. Please, let me know if $HOME/.config folder would be more appropriate.

Thank you!

[cdlm]

Installing Scale under $HOME but executables in a global place seems contradictory.
What's so bad about requiring the user to setup their $PATH?

Also, /usr/local is an acceptable install prefix in many cases. I think the install script should be configurable to install Scale in a user-specified prefix, and possibly to rely on an independently installed Pharo; that would cut most of the work for #14.

[LucFabresse]

I agree with Damien.
Install it either in /usr/local or in $HOME/.scale.
But we should not mix and the user must set his PATH in the second case.

[atykhonov]

Hello @cdlm @LucFabresse !

Sorry for the long delay and thank you very much for your review! You are right, I totally agree with you. So, I've changed everything so that scale is installed into $HOME/.scale only.

Please review.

[LucFabresse]

Hi,

Thanks for this. I think it is better.
Just one question: why did you put it in HOME/.config and not HOME/.scale directly?

Luc

[guillep]

Hi @LucFabresse, by reading the diff, I do not see he is using .config anymore. However, there is still the example file pwd.st that prints .config.

My main question is why removing the install.st file. I understand you could replace it with a rm -rf, but

• the script was only used in setupScale.sh file, but it was meant to be a part of scale's API. In other words, if you want to uninstall scale, you call the uninstall script.
• in case scale grows in complexity I'd like to have a separate script, even if it just does so far a rm -rf inside.
• I would like it to be written in scale. If we port scale to windows in the future (which is not so crazy to think about), a rm -rf solution will not work

[guillep]

BTW, related to this, I created issue #20. We should add in our test suite that scale is correctly uninstalled.

[LucFabresse]

I look at the wrong diff ;-) Yes it is better now. #Luc 2017-03-15 10:05 GMT+01:00 Guillermo <[email protected]>:

…

Hi @LucFabresse <https://github.com/LucFabresse>, by reading the diff, I do not see he is using .config anymore. However, there is still the example file pwd.st that prints .config. My main question is why removing the install.st file. I understand you could replace it with a rm -rf, but - the script was only used in setupScale.sh file, but it was meant to be a part of scale's API. In other words, if you want to uninstall scale, you call the uninstall script. - in case scale grows in complexity I'd like to have a separate script, even if it just does so far a rm -rf inside. - I would like it to be written in scale. If we port scale to windows in the future (which is not so crazy to think about), a rm -rf solution will not work — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAaXcOoVM05qwbZtNc-IeGYr__YWxtgKks5rl6njgaJpZM4K0Gax> .

[atykhonov]

My main question is why removing the install.st file. I understand you could replace it with a rm -rf, but

The main reason why I removed uninstall.st is it doesn't work well. After it finishes execution of all code in itself, Pharo' virtual machine throws an error. You could try this by reverting uninstall.st and executing it. I have no idea why this error happens and how to resolve it. Any help would be highly appreciated!

[guillep]

I'd say that we leave it there for now and then we open a separate issue about it. Like that we have smaller and simpler to integrate pull requests. What do you think?

…

On Wed, Mar 15, 2017 at 12:04 PM, Andrii Tykhonov ***@***.***> wrote: My main question is why removing the install.st file. I understand you could replace it with a rm -rf, but The main reason why I removed uninstall.st is it doesn't work well. After it finishes execution of all code in itself, Pharo' virtual machine throws an error. You could try this by reverting uninstall.st and executing it. I have no idea why this error happens and how to resolve it. Any help would be highly appreciated! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AArO4gkwVSK1ZrKKXBZsb8Qe4QRWadXeks5rl8XHgaJpZM4K0Gax> .

[atykhonov]

I think, ok, no problem. I've reverted the commits that relate to removing of uninstall.st. I created issue #21 regarding the error which occurs while uninstallation.

[atykhonov]

Btw, uninstallation does its job. What is wrong, is that the error outputs to the console, so that that could be a little bit confusing for a user. Hi might think that uninstallation went wrong.

Does the changes looks good now?

[guillep]

I discussed with @sbragagnolo and it looks ok. Thanks!

[guillep]

Somehow, this broke the build.

https://travis-ci.org/guillep/Scale/builds/211441475

Which is strange becase the validation against the PR was ok (https://travis-ci.org/guillep/Scale/pull_requests)

[atykhonov]

It fails because (I'm looking at https://travis-ci.org/guillep/Scale/jobs/211441477) scale could not be found.

It seems that travis job needs to be adjusted, i.e. path to scale needs to be added to PATH.

[atykhonov]

I suppose that between these two lines:

219 $ sudo ./setupScaleDev.sh
323 $ ./examples/lsst.st

we need export PATH="$HOME/.scale/scale:$PATH".

[guillep]

Or better PATH=$PATH:"$HOME/.scale/" I do no like messing with the precedence.

…

On Wed, Mar 15, 2017 at 6:38 PM, Andrii Tykhonov ***@***.***> wrote: I suppose that between these two lines: 219 $ sudo ./setupScaleDev.sh 323 $ ./examples/lsst.st we need export PATH="$HOME/.scale/scale:$PATH". — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AArO4rAeZg76HLCE0AqpqaBTrl9F8ZUGks5rmCH8gaJpZM4K0Gax> .